Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(chart/data-prepper) Remove demo pipeline from values, add explicit demo value #634

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

fix(chart/data-prepper) Remove demo pipeline from values, add explicit demo value #634

wants to merge 1 commit into from

Conversation

janhoy
Copy link
Contributor

@janhoy janhoy commented Dec 17, 2024

Description

This PR comments demo pipline from values, and also removes the alread-commented complex pipeline example, refering to documentation instead.

Now, when installing the chart with defaults only, the install will fail with this message:

helm.go:86: 2024-12-17 15:21:55.866789 +0100 CET m=+0.033838001 [debug] execution error at (data-prepper/templates/deployment.yaml:98:27): A valid pipeline configuration is required! Please set one of:
pipelineConfig.existingSecret - for your custom pipeline secret
pipelineConfig.enabled - for inline configuration in values.yaml or
pipelineConfig.demoPipeline=true - for a sample demo pipeline using random source and stdout sink.

If you instead install the chart with --set pipelineConfig.demoPipeline=true, the behavior will be identical to current chart behavior, and we also print an informative message in stdout about what pipeline configuration is in use:

...
The demo pipeline configuration is enabled, using the `random` source and `stdout` sink.

Issues Resolved

Fixes #624

Check List

  • Commits are signed per the DCO using --signoff

For any changes to files within Helm chart directories:

  • Helm chart version bumped
  • Helm chart CHANGELOG.md updated to reflect change

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

@prudhvigodithi
Copy link
Member

Adding @SergK to please take a look as well.
@getsaurabh02

@prudhvigodithi
Copy link
Member

Thanks @janhoy I like the approach to use --set pipelineConfig.demoPipeline=true, can you please fix the failing the CI tests?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@TheAlgo TheAlgo Awaiting requested review from TheAlgo TheAlgo is a code owner

@DandyDeveloper DandyDeveloper Awaiting requested review from DandyDeveloper DandyDeveloper is a code owner

@peterzhuamazon peterzhuamazon Awaiting requested review from peterzhuamazon peterzhuamazon is a code owner

@prudhvigodithi prudhvigodithi Awaiting requested review from prudhvigodithi prudhvigodithi is a code owner

@gaiksaya gaiksaya Awaiting requested review from gaiksaya gaiksaya is a code owner

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
first-time-contributor
Projects
Engineering Effectiveness Board
Status: No status
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[BUG][data-prepper] Chart values should not have a default pipeline defined
2 participants
@janhoy @prudhvigodithi